[Bug 196264] New: [iwn] [patch]: remove unneeded checks in iwn_scan()

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

Bug ID: 196264
Summary: [iwn] [patch]: remove unneeded checks in iwn_scan()
Product: Base System
Version: 11.0-CURRENT
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: wireless
Assignee: freebsd-***@FreeBSD.org
Reporter: ***@gmail.com

Created attachment 150952
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=150952&action=edit
Remove check for c->ic_flags & IEEE80211_CHAN_PASSIVE

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

Andriy Voskoboinyk <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #150952|0 |1
is obsolete| |

--- Comment #1 from Andriy Voskoboinyk <***@gmail.com> ---
Created attachment 153892
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153892&action=edit
Few minor fixes

- Add missing IWN_UNLOCK(sc).
- Remove redundant initialization in iwn_ioctl().

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

Andriy Voskoboinyk <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|[iwn] [patch]: remove |[iwn] [patch]: few minor
|unneeded checks in |fixes
|iwn_scan() |

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

--- Comment #2 from Andriy Voskoboinyk <***@gmail.com> ---
Created attachment 153995
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153995&action=edit
Patch-v2.diff

- Set maxfrags to IWN_MAX_SCATTER - 1 (first segment is used by the TX command)
- Remove redundant "not" from error string.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

Andriy Voskoboinyk <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #153892|0 |1
is obsolete| |
Attachment #153995|0 |1
is obsolete| |

--- Comment #3 from Andriy Voskoboinyk <***@gmail.com> ---
Created attachment 153996
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153996&action=edit
Patch-v2.diff

Mark previous patches as obsolete.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

Andriy Voskoboinyk <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #153996|0 |1
is obsolete| |

--- Comment #4 from Andriy Voskoboinyk <***@gmail.com> ---
Created attachment 156730
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156730&action=edit
Patch-v3.diff (untested)

- Pass control frames to host.
- Do not set TX timer on error.
- Free node references for unsent frames on device stop.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

Adrian Chadd <***@freebsd.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@freebsd.org

--- Comment #5 from Adrian Chadd <***@freebsd.org> ---
Hi,

Do you not have anything with iwn(4) hardware in it?

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

--- Comment #6 from Andriy Voskoboinyk <***@gmail.com> ---
(In reply to Adrian Chadd from comment #5)
No, I don't have such devices.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

--- Comment #7 from Adrian Chadd <***@freebsd.org> ---
Would you like a thinkpad with one in it?

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

--- Comment #8 from commit-***@freebsd.org ---
A commit references this bug:

Author: adrian
Date: Sat May 16 05:59:26 UTC 2015
New revision: 282999
URL: https://svnweb.freebsd.org/changeset/base/282999

Log:
Various iwn(4) fixes.

* simplify channel logic for determining RF gain setting in scan setup
* don't set TX timer on error
* free node references for unsent frames on device stop
* set maxfrags to IWN_MAX_SCATTER-1 (first segment is used by TX command)
* add missing IWN_UNLOCK() from interrupt path when the hardware
disappears.
* pass control frames to host
* nitems() instead of local macro

Tested:

* Intel 5100, STA mode

PR: kern/196264
Submitted by: Andriy Voskoboinyk <***@gmail.com>

Changes:
head/sys/dev/iwn/if_iwn.c

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196264

Andriy Voskoboinyk <***@freebsd.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|New |Closed